[alsa-devel] [PATCH] ASoC: nau8825: support different clock source for FLL function

Mark Brown broonie at kernel.org
Thu Mar 17 10:18:16 CET 2016


On Thu, Mar 17, 2016 at 11:04:20AM +0800, John Hsu wrote:
> On 3/17/2016 7:06 AM, Anatol Pomozov wrote:

> >>+       nau8825->mclk = devm_clk_get(nau8825->dev, "mclk");
> >>+       if (IS_ERR(nau8825->mclk)) {

> >Is it possible that clock system is not ready at this point and the
> >method returns -EPROBE_DEFER? If so it matches IS_ERR() but not a real
> >error and the nua8825 driver should backoff and wait a little before
> >clocks are ready.

> The function is used when playback startup not in the driver initiation.
> At this moment, we just skip mclk operation and let thing go on.
> Should driver return the errorno to machine driver to handle it?

Well, what should really be happening here is that the clock is
requested at probe time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160317/a91a3226/attachment.sig>


More information about the Alsa-devel mailing list