[alsa-devel] [PATCH v2 6/6] ASoC: Intel: Skylake: remove call to pci_dev_put

[Takashi Iwai]

On Wed, 16 Mar 2016 12:03:10 +0100,
Mark Brown wrote:
> 
> On Wed, Mar 16, 2016 at 04:22:44PM +0530, Vinod Koul wrote:
> > On Wed, Mar 16, 2016 at 10:08:29AM +0000, Mark Brown wrote:
> 
> > > Why is the fix for this not to call pci_dev_get()?
> 
> > Why do I need either, I see no reason why driver should be doing this,
> > so removed :)
> 
> Well, the PCI documentation says that drivers are expected to record a
> reference to their devices in probe().  This is a bit unusual given that
> normally the driver core takes a reference to the device for us but
> presumably there's some reason for this?

Maybe the document is obsoleted.  The PCI core, at least the probe /
remove via the normal PCI bus, takes pci_dev_get() and pci_dev_put()
already there.


Takashi