[alsa-devel] [PATCH 09/10] alsabat: use variable for thread return value

Takashi Iwai tiwai at suse.de
Fri Mar 11 14:34:15 CET 2016


On Wed, 02 Mar 2016 09:53:19 +0100,
han.lu at intel.com wrote:
> 
> From: "Lu, Han" <han.lu at intel.com>
> 
> Replace fixed "1" to variable for thread return value.
> 
> Signed-off-by: Lu, Han <han.lu at intel.com>
> 
> diff --git a/bat/alsa.c b/bat/alsa.c
> index 0a5f899..189b0e9 100644
> --- a/bat/alsa.c
> +++ b/bat/alsa.c
> @@ -309,13 +309,13 @@ void *playback_alsa(struct bat *bat)
>  	if (err != 0) {
>  		fprintf(bat->err, _("Cannot open PCM playback device: "));
>  		fprintf(bat->err, _("%s(%d)\n"), snd_strerror(err), err);
> -		retval_play = 1;
> +		retval_play = err;
>  		goto exit1;
>  	}
>  
>  	err = set_snd_pcm_params(bat, &sndpcm);
>  	if (err != 0) {
> -		retval_play = 1;
> +		retval_play = err;
>  		goto exit2;
>  	}
>  
> @@ -332,13 +332,13 @@ void *playback_alsa(struct bat *bat)
>  			fprintf(bat->err, _("Cannot open file for playback: "));
>  			fprintf(bat->err, _("%s %d\n"),
>  					bat->playback.file, -errno);
> -			retval_play = 1;
> +			retval_play = -errno;

Is the original errno still preserved at this point...?


Takashi


More information about the Alsa-devel mailing list