[alsa-devel] [PATCH 1/6] ASoC: Intel: allow for DW_DMAC_CORE as module

Mark Brown broonie at kernel.org
Wed Mar 9 03:43:26 CET 2016


On Mon, Mar 07, 2016 at 11:49:29AM -0600, Pierre-Louis Bossart wrote:
> On 3/4/16 10:03 PM, Mark Brown wrote:
> >On Thu, Mar 03, 2016 at 09:36:33PM -0600, Pierre-Louis Bossart wrote:

> >>-	depends on DW_DMAC_CORE=y && (SND_SST_IPC_ACPI = n)
> >>+	depends on (DW_DMAC_CORE != n) && (SND_SST_IPC_ACPI = n)

> >What is the expected difference between a dependency on DW_DMAC_CORE and
> >one on DW_DMAC_CORE != n?

> No functional difference, it's more to make the menuconfig options more
> obvious.
> Without this patch, menuconfig will not show the legacy byt-max98090 and
> byt-rt5640 options if the DW_DMAC_CORE is built as a module.
> While we want to encourage folks to use the newer DPCM drivers, we also want
> to leave these options accessible.

My point is that you've written the above in a very confusing manner - I
have to think about what it means while just a dependency would be clear
and obvious.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160309/eeb74a8e/attachment.sig>


More information about the Alsa-devel mailing list