[alsa-devel] [PATCH] ASoC: wm8994: codec driver should manage its own MCLK

Mark Brown broonie at kernel.org
Sat Mar 5 04:50:28 CET 2016


On Thu, Mar 03, 2016 at 02:45:35PM +0800, Zidan Wang wrote:

> +		if (snd_soc_codec_get_bias_level(codec) == SND_SOC_BIAS_STANDBY) {
>  			active_reference(codec);
> +
> +			for (i = 0; i < WM8994_NUM_MCLK; i++)
> +				if (!IS_ERR(pdata->mclk[i]))
> +					clk_prepare_enable(pdata->mclk[i]);
> +		}
>  		break;

This is unconditionally enabling both mclks but the device has a wide
range of options with what it can do with clocks, it doesn't need to use
both.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160305/1de35eaa/attachment.sig>


More information about the Alsa-devel mailing list