[alsa-devel] [PATCH v3] ASoC: imx-wm8958: add imx-wm8958 machine driver

[Nicolin Chen]

On Fri, Mar 04, 2016 at 07:15:44AM +0000, Zidan Wang wrote:

> > cpu-dai1	: The phandle of an CPU DAI controller for AIF1
> > cpu-dai2	: The phandle of an CPU DAI controller for AIF2
> > cpu-dai3	: The phandle of an CPU DAI controller for AIF3
> > 
> > > +	data->card.num_links = DAI_LINK_NUM;
> > > +	data->card.dai_link = data->dai_link;
> > 
> > Then, rather than hard coding the total DAI link number and creating
> > useless dummy links, you may create the links dynamically according to
> > the presence of the three properties above.
> 
> I don't know how to using cpu-dai1/2/3. There don't have voice and bt controller on the IMX cpu, don't have such cpu nodes.
> Do you means our hardware connection are wrong, and we must have voice and bt controller on the cpu?

Okay. I was trying to give you an excuse to have all three
aifs included, as I thought you might eventually need them
to *connect* something via DT. If you think you don't have
any idea to pre-allocate these links, you probably should
ignore my suggestion here and just follow Mark's comments:

[ Why are you mapping in dummy DAIs?  If these devices aren't connected
  then they're not connected and you shouldn't represent them.  If they
  are connected to something then describe those connections, possibly in
  followup patches if you have other devices you need to support upstream
  first. ]