[alsa-devel] [PATCH] Make alsa asound.h header more portable.

[Takashi Iwai]

On Thu, 03 Mar 2016 15:21:39 +0100,
Thomas Klausner wrote:
> 
> From: Thomas Klausner <wiz at NetBSD.org>
> 
> This header is used as-is in the alsa-lib userland library,
> which is portable to other operating systems.
> For this reason, include linux/types.h only on Linux systems.

This is needed also for building the Linux kernel.  So...

> Add sys/ioctl.h for _IOR/_IOW/etc. (works at least on *BSD and Solaris).
> 
> Signed-off-by: Thomas Klausner <wiz at NetBSD.org>
> ---
>  include/uapi/sound/asound.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index a82108e..3d581b5 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -23,7 +23,11 @@
>  #ifndef _UAPI__SOUND_ASOUND_H
>  #define _UAPI__SOUND_ASOUND_H
>  
> +#ifdef __linux__

... the following might be better.

#if defined(__KERNEL__) || defined(__linux__)

At least the same style is found in include/uapi/drm/drm.h, too.


thanks,

Takashi