[alsa-devel] Remaining compatibility patches for NetBSD

[Thomas Klausner]

On Thu, Mar 03, 2016 at 02:35:06PM +0100, Takashi Iwai wrote:
> On Thu, 03 Mar 2016 13:02:42 +0100,
> Thomas Klausner wrote:
> > 
> > Here are the remaining patches to make the build succeed on NetBSD.
> > More patches are needed for FreeBSD and Solaris, but let's take it one
> > at a time :-)
> > 
> > I think the first two (0002 and 0003) should be uncontroversial.
> > 
> > For patch 0004 it would perhaps be good to have versionsort/alphasort
> > in a central place instead of two. Do you have a suggestion where?
> > 
> > I'm not sure what to do about 0005 since you said you don't want to
> > modify include/sound/asound.h.
> 
> Right.  If we need to modify, it must be applied to Linux kernel tree
> at first, then copy back to alsa-lib.

I haven't done this before.

I see on https://www.kernel.org/doc/linux/MAINTAINERS

SOUND
M:	Jaroslav Kysela <perex at perex.cz>
M:	Takashi Iwai <tiwai at suse.com>
L:	alsa-devel at alsa-project.org (moderated for non-subscribers)
W:	http://www.alsa-project.org/
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
T:	git git://git.alsa-project.org/alsa-kernel.git
Q:	http://patchwork.kernel.org/project/alsa-devel/list/
S:	Maintained
F:	Documentation/sound/
F:	include/sound/
F:	include/uapi/sound/
F:	sound/

Against which of the two git trees should I prepare the patch?

> > endian.h seems to be unneeded on src/topology/tplg_local.h; if it's
> > needed, I can move it inside the #ifdef.
> 
> src/topology/parser.c contains the code depending on the endian.
> The include can be moved there, too.

local.h already handles endianness:

#ifdef HAVE_ENDIAN_H
#include <endian.h>
#elif defined(HAVE_SYS_ENDIAN_H)
#include <sys/endian.h>
#ifndef __BYTE_ORDER
#define __BYTE_ORDER BYTE_ORDER
#endif
#ifndef __LITTLE_ENDIAN
#define __LITTLE_ENDIAN LITTLE_ENDIAN
#endif
#ifndef __BIG_ENDIAN
#define __BIG_ENDIAN BIG_ENDIAN
#endif
#else
#error Header defining endianness not defined
#endif

So I think the endian.h include is not necessary and can just be removed.
 Thomas