[alsa-devel] byteswap.h

[Thomas Klausner]

On Thu, Mar 03, 2016 at 12:37:25PM +0100, Takashi Iwai wrote:
> On Thu, 03 Mar 2016 12:18:40 +0100,
> Thomas Klausner wrote:
> > 
> > On Thu, Mar 03, 2016 at 11:21:05AM +0100, Takashi Iwai wrote:
> > > On Thu, 03 Mar 2016 11:10:05 +0100,
> > > Thomas Klausner wrote:
> > > > 
> > > > On Thu, Mar 03, 2016 at 11:01:23AM +0100, Takashi Iwai wrote:
> > > > > Applied now.  Thanks.
> > > > 
> > > > Thank you!
> > > > 
> > > > Next big issue: Many places include byteswap.h to get bswap_16,
> > > > bswap_32, bswap_64.
> > > > 
> > > > This header does not exist on *BSD or Solaris.
> > > > 
> > > > However, all of these provide similar macros under different names,
> > > > from different header files (bswap16 etc, or BSWAP_16).
> > > > 
> > > > Do you want a compat header, e.g. include/bswap.h that takes care of
> > > > this and is included by local.h, or do you prefer a different
> > > > solution?
> > > 
> > > bswap.h looks better ATM.  Let's see.
> > 
> > Ok, here's my try for a version of bswap.h. Does it look ok?
> 
> Looks good to me -- supposing you tested it actually :)

This particular patch was only compile-tested on NetBSD, but a quite
similar ifdef has been in pkgsrc for years and has survived a number
of bulk builds over the years.
 Thomas