[alsa-devel] [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch

[John Lin]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Wednesday, March 02, 2016 6:36 PM
> To: John Lin
> Cc: lgirdwood at gmail.com; alsa-devel at alsa-project.org; Bard Liao; Flove;
> Oder Chiou; zhengsq at rock-chips.com
> Subject: Re: [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch
> 
> On Wed, Mar 02, 2016 at 05:18:40PM +0800, John Lin wrote:
> 
> >  	SOC_DOUBLE("HP Playback Switch", RT5616_HP_VOL,
> >  		   RT5616_L_MUTE_SFT, RT5616_R_MUTE_SFT, 1, 1),
> > +	SOC_DOUBLE("HP Channel Switch", RT5616_HP_VOL,
> > +		   RT5616_VOL_L_SFT, RT5616_VOL_R_SFT, 1, 1),
> 
> What does "Channel Switch" mean?  It looks like this is a mute control
> in which case it shoiuld be HP Playback Switch or similar like other
> mute controls.
> 

Yes, It is another mute control that is missing on current driver.
This mute control is for headphone volume mute. Is it OK to rename it to
'Headphone Volume Playback Switch'?


> ------Please consider the environment before printing this e-mail.