[alsa-devel] [PATCH] ASoC: nau8825: add crosstalk suppression feature

Mark Brown broonie at kernel.org
Wed Mar 2 05:31:30 CET 2016


On Mon, Feb 29, 2016 at 07:21:16AM +0800, John Hsu wrote:

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

> On 2/10/2016 2:39 AM, Mark Brown wrote:
> >On Fri, Feb 05, 2016 at 01:52:46PM +0800, John Hsu wrote:

> >>+static u32 nau8825_intlog10_dec3(u32 value)

> >This doesn't look driver specific, it should go somewhere generic
> >(though I can't immediately see any relevant place for it...).

> Do you have any advise what we can do? It's possible to move these functions
> to other files, isn't it?

Propose a maths helper library?

> It has to enable DAC and ADC path for detection and measurement. A little
> like simple playback and record.
> Indeed, it spent some time to finish the whole sequence and the situation
> you mention will happen possibly.
> Do we can add some mutex in driver to avoid something like race condition
> happened? Could you give us suggenstion? Very thanks.

Take a look at the da7219 driver, it is doing something similar.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160302/557b335c/attachment.sig>


More information about the Alsa-devel mailing list