[alsa-devel] [PATCH v2 2/6] ASoC: samsung: Add Samsung Low Power Audio Subsystem driver

[Mark Brown]

On Thu, Jun 23, 2016 at 12:45:11PM +0200, Sylwester Nawrocki wrote:
> From: Inha Song <ideal.song at samsung.com>
> 
> This patch adds LPASS driver. The LPASS (Low Power Audio Subsystem)
> is a special subsystem that supports audio playback with low power
> consumption. This is a minimal driver which prepares resources for
> IP blocks like I2S, audio DMA and UART.
> Also system power ops are added to ensure the Audio Subsystem is
> operational after system suspend/resume cycle.

This is so trivial that I'm wondering why you even need it, it does
essentially nothing except for manage power on and off, and that isn't
synced up with the rest of the audio subsystem in any discernable way.
Previous Samsung SoCs have quite happily ignored their LPASS subsystems
in mainline.  As things stand I'm concerned that systems may get broken
if more functionality is added without the joining up with the rest of
the audio hardware via a card, there's not even the hooks which would
allow that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160629/5c9cb7c0/attachment.sig>