[alsa-devel] [PATCH v2 4/6] ASoC: max98504: Add max98504 speaker amplifier driver

[Mark Brown]

On Thu, Jun 23, 2016 at 12:45:13PM +0200, Sylwester Nawrocki wrote:

> +	/* Select analog input by default */
> +	regmap_write(map, MAX98504_REG_SPEAKER_SOURCE_SELECT, 0x1);

This should be done by userspace configuration, just leave the chip at
power on defaults.  This is policy so that we don't have people trying
to patch their configurations into the kernel.

> +	/* Brownout protection enable */
> +	regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_ENABLE, 0x1);
> +	/* Threshold 2.9V, 3dB speaker attenuation*/
> +	regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(1), 0x33);
> +	/* Attack hold time 10 ms */
> +	regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(2), 0x0a);
> +	/* Brownout hold time 255 ms, brownout release time 255 ms */
> +	regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(3), 0xff);
> +	regmap_write(map, MAX98504_REG_PVDD_BROWNOUT_CONFIG(4), 0xff);

Should these be DT properties?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160627/018e1053/attachment.sig>