[alsa-devel] [RESEND PATCH v3 1/2] device property: Add function to search for named child of device
Mika Westerberg
mika.westerberg at linux.intel.com
Tue Jun 21 13:54:25 CEST 2016
On Tue, Jun 21, 2016 at 01:42:16PM +0200, Rafael J. Wysocki wrote:
> > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > + const char *name)
> > > +{
> > > + return is_acpi_data_node(fwnode) ?
> > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > +}
> >
> > Looks fine to me.
> >
> > One question - is it expected that matching ACPI data nodes is always
> > case insensitive?
>
> That would not be a correct expectation in theory, although I don't think it
> really matters in practice.
OK.
Maybe it is good idea to document that in acpi_data_node_match(). A
comment explaining why we use strcasecmp() for now.
More information about the Alsa-devel
mailing list