[alsa-devel] [PATCH RFC 3/6] ASoC: max98504: Add max98504 speaker amplifier driver
Mark Brown
broonie at kernel.org
Mon Jun 13 17:14:29 CEST 2016
On Mon, Jun 13, 2016 at 12:52:37PM +0200, Sylwester Nawrocki wrote:
> [s.nawrocki: removed unused macro definitions and regulator handling
> code, rewrote regmap config code, added support for speaker enable
> and global chip enable through DAPM, rewritten as component driver,
> redesigned DT bindings]
Removed the regulator handling code? Why?
> + default:
> + /* Analog input, disable PCM, PDM Rx */
> + regmap_write(map, MAX98504_REG_PCM_RX_ENABLE, 0);
> + regmap_write(map, MAX98504_REG_PDM_RX_ENABLE, 0);
> + }
Add a break here please, at least for consistency.
> + ret = PTR_ERR(max98504->regmap);
> + dev_err(&client->dev, "regmap initialization failed: %d\n", ret);
> + return ret;
> + }
> +
> + ret = max98504_probe(max98504);
> + if (ret < 0)
> + return ret;
Why not just inline this code?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160613/9fbee2fb/attachment.sig>
More information about the Alsa-devel
mailing list