[alsa-devel] [PATCH] ALSA: Add rate defines for 352k8 and 384k

[Takashi Iwai]

On Mon, 06 Jun 2016 14:19:00 +0200,
DigitalDreamtime wrote:
> 
> Add SNDRV_PCM_RATE_352800 and SNDRV_PCM_RATE_384000 defines to pcm.h,
>  for 352k8 and 384k sample rates.
> 
> Add SNDRV_PCM_RATE_8000_384000 define to pcm.h.
> 
> Update rates list in pcm_native.c.
> 
> Yes, we can use CONTINUOUS/KNOT and constraints, to support the x8
>  sample rates, but having the defines requires less code in drivers.

Well, it'd be more convincing if you actually show the reduction of
the code after this patch in the current tree.  The number speaks more
than words.

> Many more DAC chips are now supporting the x8 44k1/48k multiples.
> From a high-res viewpoint, the DXD standard is 352k8, 24 bit.
> That alone should justify the addition of a define for it.
> 
> Signed-off-by: DigitalDreamtime <clive.messer at digitaldreamtime.co.uk>

A sign-off has to be the real name.  Please see "sign your work"
section in SubmittingPatches.


thanks,

Takashi