[alsa-devel] [PATCH] ASoC: rt298: remove idle_bias_off = true

Mark Brown broonie at kernel.org
Fri Jun 3 01:40:19 CEST 2016


On Thu, Jun 02, 2016 at 02:51:52PM +0800, Bard Liao wrote:

> Codec will not go into suspend if there is any widget forced on with
> idle_bias_off true. We want codec go into suspend when the system is
> suspend. Also, we don't do anything in bias level OFF case. So it is
> actually no different in bias level STANDBY or OFF case.

Hrm.  This feels like something that the framework might be doing wrong
here.  We should either suspend the CODEC all the time even if there are
widgets enabled or we should never suspend the CODEC even if there are
widgets enabled but having it depend on idle_bias_off seems like the
wrong thing here.  My expectation would be that we would not suspend
with widgets on since the widgets being on implies the CODEC being on
and we'd expect suspend to do things like cutting the device level
power.  

Could you talk through the use case in more detail - what's the widget
and why is it still OK for suspend to run even with widgets on?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160603/b692f7cb/attachment.sig>


More information about the Alsa-devel mailing list