[alsa-devel] [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine

Vinod Koul vinod.koul at intel.com
Wed Jul 20 05:58:35 CEST 2016


On Tue, Jul 19, 2016 at 04:56:24PM +0200, Bastien Nocera wrote:
> > +	/* fixup codec name based on HID */
> > +	i2c_name = sst_acpi_find_name_from_hid(mach->id);
> > +	if (i2c_name != NULL) {
> > +		snprintf(cht_rt5640_codec_name, sizeof(cht_rt5640_codec_name),
> > +			"%s%s", "i2c-", i2c_name);
> > +		cht_dailink[dai_index].codec_name = cht_rt5640_codec_name;
> 
> FWIW, I get:
> sound/soc/intel/boards/cht_bsw_rt5645.c: In function 'snd_cht_mc_probe':
> sound/soc/intel/boards/cht_bsw_rt5645.c:391:37: warning: 'dai_index' may be used uninitialized in this function [-Wmaybe-uninitialized]
>    cht_dailink[dai_index].codec_name = cht_rt5640_codec_name;
>    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~

Yeah I notice them a bit later. The fixes are already in mark's-next.

-- 
~Vinod


More information about the Alsa-devel mailing list