[alsa-devel] [PATCH 07/39 v2] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Jul 4 01:54:04 CEST 2016


Hi Mark

> > > > +	if (!card->name)
> > > > +		card->name = card->dai_link->name;
> 
> > > This will unconditionally defererence dai_link but it's optional - we
> > > can have analogue only cards.
> 
> > This is not new feature. Current simple-card already has it.
> 
> Right, but simple-card does need DAIs IIRC while this is intended to be
> more general.  All it needs is a check before the dereference to be safe
> so it's trivial to handle.

Sorry, I'm not 100% understand.
Do you mean we don't need handle card->name ? (= we should remove above ?)
If so, we can't register card on simple-card. Because snd_soc_register_card()
requests it.



More information about the Alsa-devel mailing list