[alsa-devel] [PATCH] ASoC: Add max98926 codec driver

[Mark Brown]

On Thu, Jan 14, 2016 at 02:03:33PM -0800, anish kumar wrote:

> +static const struct snd_kcontrol_new max98926_dai_controls[] = {
> +	SOC_DAPM_SINGLE("Left", MAX98926_GAIN,
> +		MAX98926_DAC_IN_SEL_SHIFT, 0, 0),
> +	SOC_DAPM_SINGLE("Right", MAX98926_GAIN,
> +		MAX98926_DAC_IN_SEL_SHIFT, 1, 0),
> +	SOC_DAPM_SINGLE("LeftRight", MAX98926_GAIN,
> +		MAX98926_DAC_IN_SEL_SHIFT, 2, 0),

These are on/off switches too and so should end in Switch like all the
other on/off controls.  Other than this the driver looks good so I've
applied it, please send a followup patch correcting this.

> +	SOC_DAPM_SINGLE("(Left+Right)/2 Switch", MAX98926_GAIN,
> +		MAX98926_DAC_IN_SEL_SHIFT, 3, 0),
> +};
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160127/4ea76ca0/attachment.sig>