[alsa-devel] [PATCH 3/3] tinycompress: crec: make functions static

Vinod Koul vinod.koul at intel.com
Mon Jan 18 17:30:03 CET 2016


Sparse rightly complains some functions should be static so make them static

crec.c:113:26: warning: symbol 'blank_wave_header' was not declared. Should it be static?
crec.c:239:6: warning: symbol 'capture_samples' was not declared. Should it be static?

Signed-off-by: Vinod Koul <vinod.koul at intel.com>
---
 src/utils/crec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/crec.c b/src/utils/crec.c
index 6e8166d8f77b..8d5b7b0b2c30 100644
--- a/src/utils/crec.c
+++ b/src/utils/crec.c
@@ -110,7 +110,7 @@ struct wave_header {
 	} __attribute__((__packed__)) data;
 } __attribute__((__packed__));
 
-const struct wave_header blank_wave_header = {
+static const struct wave_header blank_wave_header = {
 	.riff = {
 		.chunk = {
 			.desc = "RIFF",
@@ -236,7 +236,7 @@ static int finish_record(void)
 	return 0;
 }
 
-void capture_samples(char *name, unsigned int card, unsigned int device,
+static void capture_samples(char *name, unsigned int card, unsigned int device,
 		     unsigned long buffer_size, unsigned int frag,
 		     unsigned int length, unsigned int rate,
 		     unsigned int channels, unsigned int format)
-- 
1.9.1



More information about the Alsa-devel mailing list