[alsa-devel] [PATCH] Revert "ASoC: fsl_ssi: remove explicit register defaults"

[Fabio Estevam]

Hi Maciej,

On Sun, Feb 21, 2016 at 4:13 PM, Maciej S. Szmigiero
<mail at maciej.szmigiero.name> wrote:
> On 21.02.2016 15:35, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam at nxp.com>
>>
>> Commit 5c408fee2546 ("ASoC: fsl_ssi: remove explicit register defaults")
>> causes the driver to fail to probe:
>>
>> fsl-ssi-dai 2028000.ssi: No cache defaults, reading back from HW
>> fsl-ssi-dai 2028000.ssi: Failed to init register map
>> fsl-ssi-dai: probe of 2028000.ssi failed with error -22
>>
>> , so revert this commit.
>>
>> Cc: Maciej S. Szmigiero <mail at maciej.szmigiero.name>
>> Reported-by: Mika Penttilä <mika.penttila at nextfour.com>
>> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
>> ---
>> Maciej,
>>
>> As this currently breaks SSI on 4.5-rc we should better revert it for
>> this cycle.
>>
>> We can then add it back to 4.7 when Mark's patch 3245d460a1eb55
>> ("regmap: cache: Fall back to register by register read for cache defaults")
>> will be available and then the driver will work fine with your patch.
>
> While I see no problem with delaying this patch to next kernel wouldn't
> it be easier to simply merge the regmap change as a fix as you
> had suggested previously?

That would work too, but as we are late in the 4.5-rc cycle we face
the risk of breaking some other drivers after applying 3245d460a1eb55
("regmap: cache: Fall back to register by register read for cache
defaults").

So either this revert or applying 3245d460a1eb55 would work, but the
revert is bit safer IMHO.