[alsa-devel] [PATCH] ASoC: Add max9867 codec driver

Mark Brown broonie at kernel.org
Thu Feb 18 15:16:11 CET 2016


On Wed, Feb 17, 2016 at 05:28:49PM -0800, anish kumar wrote:

> +			if (pclk_bclk_ratio == 2)
> +				bclk_value = MAX9867_IFC1B_PCLK_2;
> +			else if (pclk_bclk_ratio == 4)
> +				bclk_value = MAX9867_IFC1B_PCLK_4;
> +			else if (pclk_bclk_ratio == 8)
> +				bclk_value = MAX9867_IFC1B_PCLK_8;
> +			else if (pclk_bclk_ratio == 16)
> +				bclk_value = MAX9867_IFC1B_PCLK_16;
> +			else {
> +				dev_err(codec->dev, "unsupported sampling rate\n");
> +				return -EINVAL;
> +			}
> +			break;

This looks like a switch statement, please write it as a switch
statement.  Please send a followup patch implementing this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160218/57431479/attachment.sig>


More information about the Alsa-devel mailing list