[alsa-devel] [PATCH] ASoC: sigmadsp: Fix missleading return value
pascal.huerst at gmail.com
pascal.huerst at gmail.com
Wed Feb 10 15:59:28 CET 2016
From: Pascal Huerst <pascal.huerst at gmail.com>
Forwarding the return value of i2c_master_send, leads to errors
later on, since i2c_master_send returns the number of bytes
transmittet. Check for ret < 0 instead and return 0 otherwise.
Signed-off-by: Pascal Huerst <pascal.huerst at gmail.com>
---
sound/soc/codecs/sigmadsp-i2c.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c
index 21ca3a5..d374c18 100644
--- a/sound/soc/codecs/sigmadsp-i2c.c
+++ b/sound/soc/codecs/sigmadsp-i2c.c
@@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,
kfree(buf);
- return ret;
+ if (ret < 0)
+ return ret;
+
+ return 0;
}
static int sigmadsp_read_i2c(void *control_data,
--
2.4.3
More information about the Alsa-devel
mailing list