[alsa-devel] [PATCH v5 01/14] ASoC: hdac_hdmi: Add hotplug notification and read eld

[Vinod Koul]

On Tue, Feb 09, 2016 at 07:42:06PM +0000, Mark Brown wrote:
> On Sat, Jan 30, 2016 at 07:13:35PM +0530, Subhransu S. Prusty wrote:
> 
> > +	if (!pin->eld.monitor_present || !pin->eld.eld_valid) {
> > +
> > +		dev_info(&edev->hdac.dev, "%s: disconnect for pin %d\n",
> > +						__func__, pin->nid);
> > +		goto put_hdac_device;
> 
> Will this get noisy?

Not really, we print when we get the hotplug notification. Usually that wont
happen too often unless someone is moneky testing :)

> 
> > +		/* TODO: use i915 component for reading ELD later */
> > +		if (hdac_hdmi_get_eld(&edev->hdac, pin->nid,
> > +				pin->eld.eld_buffer,
> > +				&pin->eld.eld_size) == 0) {
> > +
> > +			print_hex_dump_bytes("Eld: ", DUMP_PREFIX_OFFSET,
> > +					pin->eld.eld_buffer, pin->eld.eld_size);
> 
> ELD is an acronym, please write it properly (there's some other examples
> in the patch).

ELD is quite often used acronym in HDMI world, It is already there in
drivers (did a quick grep :)

I will update this and any other acronyms..

> 
> > +		} else {
> > +			dev_err(&edev->hdac.dev, "ELD invalid\n");
> > +			pin->eld.monitor_present = false;
> > +			pin->eld.eld_valid = false;
> > +		}
> 
> Is it really invalid or did we fail to read it?  There's a difference as
> far as debugging is concerned (one means there's an I/O problem, the
> other means that the display is reporting nonsense).  Perhaps this
> should be silent and let the read function be more specific?

There is no way to know if this was IO or garbage from display. So we just
throw up error and retry few times.

-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160210/dca1d305/attachment.sig>