[alsa-devel] [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT

Lars-Peter Clausen lars at metafoo.de
Wed Feb 3 09:24:25 CET 2016


On 02/02/2016 08:30 PM, Mark Brown wrote:
> On Tue, Feb 02, 2016 at 04:38:04PM +0000, Charles Keepax wrote:
> 
>> +#define ARIZONA_48K_RATES 12000, 24000, 48000, 96000, 192000, 4000, 8000, \
>> +			  16000, 32000
> 
> This just looks wrong.  It's valid code but with the combination of the
> split line and the list without any sort of parenthesis it sets off
> alarm bells.  Duplicating might not be the worst thing ever...

For list constraints it is possible to specify a mask for which of the
entries in the rates array should be considered. So you could use the same
rate array, but use different masks. The adau1977 drive for example does this.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160203/084bc15f/attachment.sig>


More information about the Alsa-devel mailing list