[alsa-devel] [PATCH] ASoC: rt5645: add "coreboot" to dmi_system_id list

[Mark Brown]

On Mon, Feb 01, 2016 at 01:21:18PM +0800, Bard Liao wrote:

> +	{
> +		.ident = "Google Chrome",
> +		.matches = {
> +			DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
> +		},
> +	},

While coreboot is most commonly seen in ChromeOS systems it's not unique
to them so this seems likely to generate false positives.  Since the
target for this change is internal-only development hardware it doesn't
seem unreasonable to expect people to be able to keep changes like
device ID updates internally.  This is one of the many costs of BIOSes
that require us to do such DMI hacks, it'd be much better to improve the
firmware and the driver so they can specify required properties directly
rather than relying on DMI.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160202/33d7fc0c/attachment.sig>