[alsa-devel] [PATCH 2/2] ASoC: cs43130: Add devicetree bindings for CS43130

[Rob Herring]

On Wed, Dec 07, 2016 at 02:17:28PM -0600, Li Xu wrote:
> Add devicetree bindings documentation file for Cirrus
> Logic CS43130 codec.
> 
> Signed-off-by: Li Xu <li.xu at cirrus.com>
> ---
>  .../devicetree/bindings/sound/cs43130.txt          | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/cs43130.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/cs43130.txt b/Documentation/devicetree/bindings/sound/cs43130.txt
> new file mode 100644
> index 0000000..9a2a22a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cs43130.txt
> @@ -0,0 +1,41 @@
> +CS43130 DAC
> +
> +Required properties:
> +
> +  - compatible : "cirrus,cs43130"
> +
> +  - reg : the I2C address of the device for I2C
> +
> +  - VA-supply, VP-supply, VL-supply, VCP-supply, VD-supply:
> +	power supplies for the device, as covered in
> +	Documentation/devicetree/bindings/regulator/regulator.txt.
> +
> +
> +Optional properties:
> +
> +  - reset-gpios : gpio used to reset the Device

Please state the active state and set that in the flag cell.

> +
> +  - cirrus,xtal-ibias:
> +   When external MCLK is generated by external crystal
> +   oscillator, CS43130 can be used to provide bias current
> +   for external crystal.  Amount of bias current sent is
> +   set as:
> +   1 = 7.5uA
> +   2 = 12.5uA
> +   3 = 15uA
> +
> +Example:
> +
> +cs43130: cs43130 at 30 {

audio-codec at 30

> +	compatible = "cirrus,cs43130";
> +	reg = <0x30>;
> +	reset-gpios = <&axi_gpio 54 0>;
> +   VA-supply = <&dummy_vreg>;

Some whitespace problems here.

> +   VP-supply = <&dummy_vreg>;
> +   VL-supply = <&dummy_vreg>;
> +   VCP-supply = <&dummy_vreg>;
> +   VD-supply = <&dummy_vreg>;
> +   cirrus,xtal-ibias = <2>;
> +   interrupt-parent = <&gpio0>;
> +   interrupts = <55 8>;
> +};
> -- 
> 1.9.1
>