[alsa-devel] [PATCH 2/3] ASoC: rsrc-card: rename rsrc-card to simple-dpcm-card phase2

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon Aug 22 09:12:50 CEST 2016


Hi Mark again

> > > -- compatible				: "renesas,rsrc-card{,<board>}"
> > > -					  Examples with boards are:
> > > -					    - "renesas,rsrc-card"
> > > -					    - "renesas,rsrc-card,lager"
> > > -					    - "renesas,rsrc-card,koelsch"
> > > +- compatible				: "simple-dpcm-audio-card"
> > > +
> > 
> > Since the card is already in released kernels we can't just remove the
> > old compatible strings, we should continue to support them.  I'm also a
> > bit unsure about adding a generic DPCM compatible string - it really is
> > a Linux specific thing.  While code reuse in the implementation is good
> > so factoring out the card is good I'm not sure we want to bake in the
> > idea that this is a strong abstraction so keeping a list of specific
> > compatible strings might be better.
> 
> OK, I see.
> This driver was used for Renesas SCU (Sampling Rate Converter Unit) which
> is including SRC (Sampling Rate Converter), CTU (Channel Transfer Unit), MIX (Mixer),
> 1 or more CPU and 1 Codec system.
> (Original was only for SRC, rsrc = Renesas SRC)
> 
> Can I use simple-scu-audio-card ? If OK, I can send such patch.

I can keep "renesas,rsrc-card" compatible,
but I would like to remove above "board" specific compatible,
because it exists in my test environment only. No one is using it.
And it makes this driver very complex.

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list