[alsa-devel] [PATCH 00/15] Line6 POD X3/X3Live suport

[Takashi Iwai]

On Thu, 11 Aug 2016 21:02:12 +0200,
Andrej Krutak wrote:
> 
> Hello all,
> 
> 
> attached is the first version of the driver, based on POD HD. They share a lot
> of similarities, but at the same time there were some generalizations needed. I
> think POD HD could follow up on these patches to add hwdep support, perhaps
> helix too... I tried to not introduce regressions to the old HW.
> 
> Anyhow, this is probably not the final version of the patches, as it is my
> first submission to upstream - I'm sure there will be some issues.
> Especially the patch
> "Use device_create_file instead of snd_card_add_dev_attr" I have to revisit,
> it may not be necessarry in the end.
> 
> Other than that, the patches mostly pass `make checkpatches`. I've been
> testing the driver for a while now, including lock debugging options etc.,
> and there don't seem to be functional problems.
> 
> There's one missing thing - the driver uses bulk USB interface of the
> device, but so far I wasn't able to make the usb_driver_claim_interface()
> work... I hope this can be added later, if someone (or I) finds time.
> 
> 
> Thanks for your inputs, greetings,

Thanks for the patches.  Many of them look good, but we'd need
revisiting some of them.  But at the next time, please put maintainers
to Cc, not only to sending to ML.

I'll comment on each patch.


Takashi