[alsa-devel] [PATCH v5 2/2] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board

[Mark Brown]

On Tue, Aug 09, 2016 at 04:21:54PM +0200, Sylwester Nawrocki wrote:

> +		card->dai_link[i].codec_of_node = codec_dai_node;
> +		card->dai_link[i].cpu_of_node = cpu_dai_node;
> +		card->dai_link[i].platform_of_node = cpu_dai_node;
> +	}
> +
> +	priv->codec_mclk1 = of_clk_get_by_name(codec_dai_node, "mclk1");
> +	if (IS_ERR(priv->codec_mclk1)) {

So, all this of_clk_get_by_name() stuff is messy and is going to need to
be duplicated for any cards using this CODEC which isn't excellent.  It
would be a lot nicer if we just did some regular clk_get() calls in the
MFD and then provided an interface for other drivers to get at those
clocks (or just had the CODEC driver DTRT internally).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160809/26d43cc9/attachment-0001.sig>