[alsa-devel] [PATCH v3 1/5] ALSA: hda - move bus_parse_capabilities to core

[Vinod Koul]

On Wed, Aug 03, 2016 at 06:09:13PM +0200, Takashi Iwai wrote:

> > +		dev_dbg(bus->dev, "Capability version: 0x%x\n",
> > +				((cur_cap & AZX_CAP_HDR_VER_MASK) >> AZX_CAP_HDR_VER_OFF));
> 
> Too much indentation.  Also the parentheses are superfluous (unlike
> below).

Okay, I didn't modify this piece and copied. Will update this.

> 
> > +
> > +		dev_dbg(bus->dev, "HDA capability ID: 0x%x\n",
> > +				(cur_cap & AZX_CAP_HDR_ID_MASK) >> AZX_CAP_HDR_ID_OFF);
> 
> Too much indentation.

ok

> > +		/* read the offset of next capabiity */
> 
> A typo.

ok

-- 
~Vinod