[alsa-devel] [PATCH 1150/1285] Replace numeric parameter like 0444 with macro
Baole Ni
baolex.ni at intel.com
Tue Aug 2 14:20:50 CEST 2016
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
---
sound/core/pcm_memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index b45f6aa..f93f9cd 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -32,11 +32,11 @@
#include <sound/initval.h>
static int preallocate_dma = 1;
-module_param(preallocate_dma, int, 0444);
+module_param(preallocate_dma, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(preallocate_dma, "Preallocate DMA memory when the PCM devices are initialized.");
static int maximum_substreams = 4;
-module_param(maximum_substreams, int, 0444);
+module_param(maximum_substreams, int, S_IRUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(maximum_substreams, "Maximum substreams with preallocated DMA memory.");
static const size_t snd_minimum_buffer = 16384;
--
2.9.2
More information about the Alsa-devel
mailing list