[alsa-devel] [PATCH] sound: Fix empty menuconfig SND_ARM

[Takashi Iwai]

On Sun, 31 Jul 2016 11:05:07 +0200,
Robert Jarzmik wrote:
> 
> Eugeniu Rosca <roscaeugeniu at gmail.com> writes:
> 
> > On Sat, Jul 30, 2016 at 04:14:24PM +0200, Robert Jarzmik wrote:
> >> Eugeniu Rosca <roscaeugeniu at gmail.com> writes:
> >> 
> >> > commit 3c8f7710c1c4 ("ASoC: fix broken pxa SoC support") has removed
> >> > the SND_ARM dependency from SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97,
> >> > by moving these config entries outside of the "if SND_ARM ... endif"
> >> > construct.
> >> >
> >> > However, by placing these 2 symbols right between the SND_ARM
> >> > menuconfig definition and the first SND_ARM menu entry, the side
> >> > effect is that the SND_ARM menu becomes empty and all the config
> >> > entries caught between "if SND_ARM ... endif" no more belong to
> >> > menuconfig SND_ARM, but to its parent (menuconfig SND).
> >> >
> >> > Fix this.
> >> NAK.
> >> 
> >> The reason is that SND_PXA2XX_LIB is used outside of SND_ARM, see
> >> sound/soc/pxa/Kconfig, SND_PXA2XX_SOC and co.
> >> 
> >> With you commit you're breaking every board relying on SND_PXA2XX_SOC but not
> >> SND_ARM.
> >> 
> >> Cheers.
> >> 
> >> --
> >> Robert
> >
> > Hi Robert and thanks for the quick reply!
> 
> Hi Eugeniu,
> 
> Thanks for the explanation, it's very clear.
> 
> Moreover I reread your patch, and tested it, and you're actually putting the
> SND_PXA2XX_LIB and SND_PXA2XX_LIB_AC97 _after_ the endif, while I was reading
> you put them in the middle of "if ARM ... endif", hence my initial complaint.
> 
> Therefore, I remove my NAK, and :
> Acked-by: Robert Jarzmik <robert.jarzmik at free.fr>

OK, thanks, I applied this one now.

Although it looks like a silly workaround, the real problem is rather
the syntax of menuconfig, which ambiguously defines the suboptions, so
this seems to be a reasonable fix at the right moment.


Takashi