[alsa-devel] [PATCH v3 1/3] conf: topology: Add Skylake i2s conf

[Vinod Koul]

On Thu, Apr 21, 2016 at 09:22:09AM +0200, Takashi Iwai wrote:
> > +++ b/src/conf/topology/sklrt286/Makefile.am
> > @@ -0,0 +1,11 @@
> > +alsaconfigdir = @ALSA_CONFIG_DIR@
> > +SUBDIRS = data
> > +sklrt286dir = $(alsaconfigdir)/topology/sklrt286
> > +sklrt286_DATA = skl_i2s.conf
> > +EXTRA_DIST = sklrt286_DATA
> 
> Isn't it $(sklrt286_DATA)?

Yes, will fix

> > +install-data-hook:
> > +	cp -p media0_in-cpr-0.bin media0_in-mi.bin media0_out-mo.bin media0_out-cpr-6.bin codec0_out-mo.bin codec0_out-cpr-4.bin codec1_out-mo.bin codec1_out-cpr-5.bin codec0_in-cpr-1.bin codec0_in-mi.bin dmic01_hifi_in-cpr-3.bin dmic01_hifi_in-mi.bin hdmi1_pt_out-cpr-7.bin hdmi1_pt_out-cpr-8.bin hdmi2_pt_out-cpr-9.bin hdmi2_pt_out-cpr-10.bin hdmi3_pt_out-cpr-11.bin hdmi3_pt_out-cpr-12.bin $(sklrt286dir)
> 
> I guess these bin files aren't present or generated in this patch?
> This would break bisection.

Okay, will move this to second one

-- 
~Vinod