[alsa-devel] [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286

Vinod Koul vinod.koul at intel.com
Thu Apr 21 12:53:04 CEST 2016


On Thu, Apr 21, 2016 at 09:19:56AM +0200, Takashi Iwai wrote:
> On Thu, 21 Apr 2016 08:27:35 +0200,
> Vinod Koul wrote:
> > 
> > This series adds SKL-i2c conf for simple PCM  topology graph
> > 
> > Changes in v3:
> > 
> >  - remove bin blobs, now they are generated in install step
> 
> This isn't good in general.  Usually all installed files are generated
> in the normal make step, and make-install only copies them.  There are
> a few reasons:
> - Invoking a random program as root is a security risk.
> - This may create a file by root in the working directory, and either
>   it's not always possible (e.g. on NFS) or it may be left undeletable
>   after make install.

Right, that is good point indeed.

So what is your suggestion then?

Thanks
-- 
~Vinod


More information about the Alsa-devel mailing list