[alsa-devel] [PATCH] ASoC: Add max98371 codec driver

[Mark Brown]

On Fri, Apr 08, 2016 at 05:09:09AM +0200, Lars-Peter Clausen wrote:

> > +	ret = regmap_read(max98371->regmap, MAX98371_VERSION, &reg);
> > +	if (ret < 0) {
> > +		dev_info(&i2c->dev, "device error %d\n", ret);
> > +		return ret;
> > +	}
> > +	dev_info(&i2c->dev, "device version %x\n", reg);

> Drop this, it is just noise in the boot log.

It's generally OK to print information about the actual hardware found
in the system, it can be a helpful diagnostic.  Getting all this stuff
into sysfs files would be even better but that doesn't seem to be how we
do things at the minute.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20160410/d13d245b/attachment.sig>