[alsa-devel] [PATCH v2] ASoC: rt5514: add rt5514 SPI driver

[Oder Chiou]

> On Thu, Mar 31, 2016 at 06:29:51AM +0000, Oder Chiou wrote:
> > > > +static void rt5514_enable_dsp_prepare(struct rt5514_priv *rt5514)
> > > > +{
> > > > +	/* Reset */
> > > > +	regmap_write(rt5514->i2c_regmap, 0x18002000, 0x000010ec);
> 
> > > This is a *very* big table of magic numbers with what look like
> > > system specific settings in there (there seem to be some things
> > > routing to and from the ADC, and some clocking setup...).  Are you
> > > sure none of this depends on the runtime configuration?
> 
> > Yes, it is independent of the ASoC runtime configuration. The table of
> > magic numbers is the settings for the voice wake up, so it is not
> > required to be run on ASoC framework.
> 
> Are you *positive* about that?  There look to be routing things going on for
> example which might be system dependant.
> 
They are the default settings for the our common hardware planning. If the
developer wants to modify the settings to match the different hardware
planning, they can consider to change the settings in the DSP firmware.