[alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
kbuild test robot
lkp at intel.com
Mon Sep 28 11:10:29 CEST 2015
sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Songjun Wu <songjun.wu at atmel.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---
atmel-classd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla
dd->gclk = devm_clk_get(dev, "gclk");
if (IS_ERR(dd->aclk)) {
- ret = PTR_ERR(dd->gclk);
+ ret = PTR_ERR(dd->aclk);
dev_err(dev, "failed to get GCK clock: %d\n", ret);
return ret;
}
More information about the Alsa-devel
mailing list