[alsa-devel] [PATCH v2 1/9] ASoC: Intel: Skylake: Add pipe and modules handlers

Mark Brown broonie at kernel.org
Mon Sep 21 18:36:05 CEST 2015


On Mon, Sep 21, 2015 at 09:07:13AM +0530, Vinod Koul wrote:
> On Sat, Sep 19, 2015 at 09:00:23AM -0700, Mark Brown wrote:
> > On Mon, Aug 17, 2015 at 10:56:36PM +0530, Vinod Koul wrote:

> > > +	if (skl->resource.mem + mconfig->pipe->memory_pages > skl->resource.max_mem) {
> > > +		dev_err(ctx->dev, "exceeds ppl memory available=%d > mem=%d\n",
> > > +				skl->resource.max_mem, skl->resource.mem);
> > > +		return false;
> > > +	}

> > I'm not sure how the user is going to be able to tell what exceeded the
> > maximum memory here.  

> Module Id and Instance Id are printed before this but yes that is debug, so
> merging the two to error alone makes sense, will do that here

They're printed at debug level so might not appear but this is an error
message.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150921/97c67f3d/attachment.sig>


More information about the Alsa-devel mailing list