[alsa-devel] Missing return check of of_property_read_*()

[Mark Brown]

On Wed, Sep 09, 2015 at 05:05:18PM +0200, Takashi Iwai wrote:
> Brian Austin wrote:

> > Shouldn't that build server at Intel catch these? I usually get emails 
> > about things like this from them.

> Maybe depending on gcc version.  But it's interesting if no other
> static analyzer hits this, too.

It'll be because nobody is checking !OF ASoC configurations and paying
attention to warnings - with !OF the functions are inline in the header
and the compiler can tell nothing happens.

> I'm considering whether adding __must_check to of_property_read*()
> would make sense.  Then it'll be caught no matter which gcc version is
> used.  But this would hit too many spots.

Well, if they're all buggy...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150909/a986e232/attachment.sig>