[alsa-devel] [PATCH] [RFC] ASoC: rsnd: Add missing initialization of ADG req_rate

[Kuninori Morimoto]

Hi Geert

> If the "clock-frequency" DT property is not found, req_rate is used
> uninitialized, and the "audio_clkout" clock will be created with an
> arbitrary clock rate.
> 
> This uninitialized kernel stack data may leak to userspace through
> /sys/kernel/debug/clk/clk_summary, cfr. the value in the "rate" column:
> 
>        clock     enable_cnt  prepare_cnt        rate   accuracy   phase
>     --------------------------------------------------------------------
>      audio_clkout         0            0  4001836240          0 0
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>

> Should the absence of this property be considered an error?
> 
> Documentation/devicetree/bindings/sound/renesas,rsnd.txt states that
> both "#clock-cells" and "clock-frequency" are required properties, but
> none of the R-Car Gen1 and Gen2 DTSes seem to have them?

This clkout is option for each board
will fix