[alsa-devel] [PATCH v2 2/6] ASoC: hdac-hdmi: Add hdmi driver

Takashi Iwai tiwai at suse.de
Mon Oct 26 08:29:42 CET 2015


On Mon, 26 Oct 2015 02:07:49 +0100,
Vinod Koul wrote:
> +/*
> + * Parse all nodes and store the cvt/pin nids in array
> + * Add one time initialization for pin and cvt widgets
> + */
> +static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev)
> +{
....
> +	/*
> +	 * Currently on board only 1 pin and 1 converter enabled.
> +	 * So using fixed map for dai_id:pin:cvt
> +	 */
> +	return hdac_hdmi_init_dai_map(edev, &hdmi->dai_map[0], hdmi->pin_nid[0],
> +			hdmi->cvt_nid[0], 0);

Isn't this assumption too naive?
And such a restriction has to be written more clearly in the
changelog.


thanks,

Takashi


More information about the Alsa-devel mailing list