[alsa-devel] [PATCH v2 3/3] ASoC: cs47l24: Add driver for Cirrus Logic CS47L24 and WM1831 codecs

[Mark Brown]

On Mon, Oct 19, 2015 at 03:13:47PM +0100, Richard Fitzgerald wrote:

> @@ -134,6 +134,7 @@ config SND_SOC_ALL_CODECS
>  	select SND_SOC_WM5100 if I2C
>  	select SND_SOC_WM5102 if MFD_WM5102
>  	select SND_SOC_WM5110 if MFD_WM5110
> +	select SND_SOC_CS47L24 if MFD_CS47L24
>  	select SND_SOC_WM8350 if MFD_WM8350
>  	select SND_SOC_WM8400 if MFD_WM8400
>  	select SND_SOC_WM8510 if SND_SOC_I2C_AND_SPI

Please keep the Makefile and Kconfig sorted.

> +config SND_SOC_CS47L24
> +	tristate "TEST cs47l24"
> +

This isn't a good help text for the symbol.

Otherwise the code looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151022/0a8a36f4/attachment-0001.sig>