[alsa-devel] [PATCH 00/18] ALSA: Add helper function to add single value constraint

Takashi Iwai tiwai at suse.de
Tue Oct 20 11:00:15 CEST 2015


On Mon, 19 Oct 2015 07:37:04 +0200,
Takashi Iwai wrote:
> 
> On Sun, 18 Oct 2015 15:39:15 +0200,
> Lars-Peter Clausen wrote:
> > 
> > Apologies if you got this series twice, forgot to Cc the mailinglist on
> > the first try.
> > 
> > This series introduces a new helper function which can be used to constrain
> > a configuration parameter to a single. So far the recommended and most
> > efficient way to do this was to set a min-max constraint with the same
> > value for minimum and maximum. It is not necessarily immediately obvious
> > though that this is the right way to do things and some driver have come up
> > with different ways to achieve the same effect, e.g. by installing a list
> > constraint with a single item. This is less efficient since list
> > constraints are dynamic constraints which needed to be re-evaluated
> > multiple times at runtime while a min-max constraint is a static
> > constraint.
> > 
> > The function introduced in this patch series is called
> > snd_pcm_hw_constraint_single() which hopefully is semantically more
> > expressive and makes it clear that this is the function to use when setting
> > a single value constraint.
> > 
> > All existing drivers that want to set a single value constraint are update
> > to use the new helper function.
> 
> Looks good to me.  I suppose I'd take all these (including ASoC ones)
> through my tree as it adds a new API function.  Mark are you OK with
> it?

I created topic/hw-constraint-single branch in sound git tree
containing all these patches.  I'm going to keep it for a while for
further acks and merge later.


thanks,

Takashi


More information about the Alsa-devel mailing list