[alsa-devel] [patch] ALSA: firewire-tascam: off by one in identify_model()

Dan Carpenter dan.carpenter at oracle.com
Sat Oct 17 14:02:32 CEST 2015


On Sat, Oct 17, 2015 at 12:11:58PM +0200, Takashi Iwai wrote:
> On Thu, 15 Oct 2015 20:18:29 +0200,
> Dan Carpenter wrote:
> > 
> > In the original code, we potentially put a NUL character in model[8] and
> > it caused a static checker warning.  We can put the NUL in model[7]
> > instead.
> 
> I guess it's better to expand model[] to 9 bytes instead.  The logic
> is to retrieve the string from the config rom, and it's up to 8
> letters.

Ok.  I will resend.

regards,
dan carpenter



More information about the Alsa-devel mailing list