[alsa-devel] [PATCH v3] ASoC: rt5645: Add the HW EQ for the customized speaker output of Google Celes

[Mark Brown]

On Thu, Oct 08, 2015 at 11:21:33AM +0800, Oder Chiou wrote:

> +	if (!request_firmware(&fw, "rt5645_hweq.bin", codec->dev)) {
> +		rt5645->hweq.num = fw->size / sizeof(struct rt5645_eq_param_s);
> +		rt5645->hweq.param = devm_kmemdup(codec->dev, fw->data,
> +					fw->size, GFP_KERNEL);
> +		if (rt5645->hweq.param) {

I was expecting to see an ALSA binary control (I believe I explicitly
mentioned that...).  Why move to firmware?  If nothing else it's more
cumbersome during tuning.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151012/f0735f0c/attachment.sig>