[alsa-devel] [PATCH] ASoC: rt286: Fix the runtime error in the booting

[Mark Brown]

On Mon, Oct 05, 2015 at 04:09:58AM +0000, Oder Chiou wrote:

> > This isn't obvious and seems likely to break - why is this ever being
> > modified and how is that safe?

> The table was used for the cache function of the index table, so it would be
> changed the value in the index register writing. The breaking is in that the
> variable of type "const" is changing. And the wrong modification was
> committed by "c418a84a8c8f98b1a0f30cd68d0cdf40d77aed01". The modifications of
> the commit are correct in the conventional case, but it will be breaking in
> case of rt286 and rt298.

I'm sorry but this isn't clarifying anything at all for me.  You are
simply stating that this is safe but not explaning why - you need to
explain why.  If nothing else if a driver is modifying global static
data that's bad practice, the driver should be copying the data into
somewhere driver private and then modifying that.

Please also remember to include human readable descriptions of commits
so that any humans reading your mail can do so directly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151005/e921db9a/attachment.sig>