[alsa-devel] [PATCH 1/7] ALSA: firewire-tascam: add skeleton for TASCAM FireWire series

[Clemens Ladisch]

Takashi Iwai wrote:
> kbuild test robot wrote:
>>>> sound/firewire/tascam/tascam.c:23:16: sparse: cast to restricted __be32
>>
>>   > 23		data = be32_to_cpu(fw_dev->config_rom[28]);
>
> The code itself looks correct.  data is CPU endian.
> The problem looks rather like that fw_dev->config_rom[] is u32.
>
> Stefan, can it be changed to __be32 instead?

config_rom[] is CPU endian, too.

Strings should be read with fw_csr_string().


Regards,
Clemens