[alsa-devel] [PATCH] ASoC: sigmadsp: Add check for return value of i2c_master_send

[pascal.huerst at gmail.com]

From: Pascal Huerst <pascal.huerst at gmail.com>

i2c_master_send returns the number of bytes transmitted, which leads
to an error in the firmware download function. Check for the return
value and only return it directly, if it is an actual error number.

Signed-off-by: Pascal Huerst <pascal.huerst at gmail.com>
---
 sound/soc/codecs/sigmadsp-i2c.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c
index 21ca3a5..d374c18 100644
--- a/sound/soc/codecs/sigmadsp-i2c.c
+++ b/sound/soc/codecs/sigmadsp-i2c.c
@@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data,

 	kfree(buf);

-	return ret;
+	if (ret < 0)
+		return ret;
+
+	return 0;
 }

 static int sigmadsp_read_i2c(void *control_data,
--
2.4.3